Closed DLu closed 2 years ago
Hi, thanks for the submission! I've created an internal ticket to follow this contribution, and the team will get back to you with updates.
As an FYI, I'm updating the name of this PR to match our internal ticket number to pass the jira-link
Github Action.
Is there anything I can do to assist in the review process?
Is there anything I can do to assist in the review process?
Hi, sorry for the delay, I will be reviewing this today.
Even with this fix, I'm not receiving the latched message. How are you testing it?
Let's just implement custom QoS settings per publisher, instead of trying to translate ROS1 concepts.
Is this project still active within Unity?
Proposed change(s)
Resolves TODO in code, by reading
latch
parameter and setting QoS accordingly.Types of change(s)
Testing and Verification
I created a publisher in Unity with latch=true
Without the fix, a latched subscriber will not recieve the message if it joins after the message is first published.
Test Configuration:
Checklist
dev
branchdev
branchOther comments