Unity-Technologies / ROS-TCP-Endpoint

ROS package used to create an endpoint to accept ROS messages sent from a Unity scene using the ROS TCP Connector scripts
Apache License 2.0
177 stars 118 forks source link

Added the ip and port as launch arguments in the ros2 launch file #145

Open Elie-Y opened 2 years ago

Elie-Y commented 2 years ago

Proposed change(s)

Modified the ros2 launch file by adding the Ip and Port as launch arguments

Types of change(s)

Testing and Verification

I tested it using ROS2 Galactic, ros2 launch ros_tcp_endpoint endpoint.py ROS_IP:=127.0.0.1 ROS_TCP_PORT:=10001

Test Configuration:

Checklist

Other comments

unity-cla-assistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

StephanHasler commented 2 years ago

BTW: The naming of the parameters is inconsistent with the ROS1 version. There the parameters are tcp_ip and tcp_port. Also the internal variables are called likewise. See #123 why the ROS1 naming might be preferable.