fixed dash-separated user warning - Githubissues

Unity-Technologies / ROS-TCP-Endpoint

ROS package used to create an endpoint to accept ROS messages sent from a Unity scene using the ROS TCP Connector scripts

Apache License 2.0

177 stars 118 forks source link

fixed dash-separated user warning #146

Open JToolGD opened 2 years ago

JToolGD commented 2 years ago

Proposed change(s)

When building the code I got the following warnings:

UserWarning: Usage of dash-separated 'script-dir' will not be supported in future versions. Please use the underscore name 'script_dir' instead

UserWarning: Usage of dash-separated 'install-scripts' will not be supported in future versions. Please use the underscore name 'install_scripts' instead

Types of change(s)

[x] Bug fix

Testing and Verification

I did as the user warning said and simply replaced the dash with an underscore.

Test Configuration:

Unity machine OS + version: [Ubuntu 20.04]
ROS machine OS + version: [Ubuntu 20.04, ROS2 Foxy]

Checklist

[x] Ensured this PR is up-to-date with the dev branch
[x] Created this PR to target the dev branch
[x] Followed the style guidelines as described in the Contribution Guidelines
[ ] Added tests that prove my fix is effective or that my feature works
[ ] Updated the Changelog and described changes in the Unreleased section
[ ] Updated the documentation as appropriate

Other comments

unity-cla-assistant commented 2 years ago

All committers have signed the CLA.