Unity-Technologies / URDF-Importer

URDF importer
Apache License 2.0
230 stars 71 forks source link

Disable stl Postprocessing #123

Closed hyounesy closed 3 years ago

hyounesy commented 3 years ago

Proposed change(s)

Disabled the existing behaviour of URDF Importer overwriting existing assets in a Unity project. Instead:

Useful links (GitHub issues, JIRA tickets, forum threads, etc.)

https://github.com/Unity-Technologies/URDF-Importer/issues/121 https://jira.unity3d.com/browse/AIRO-908

Provide any relevant links here.

Types of change(s)

Testing and Verification

  1. Copy a new URDF directory that includes .stl files into the asset folder: Note that no .asset or .prefab file will be created for the .stl mesh files.
  2. From main menu select Assets > Reimport: Again note that no .asset or .prefab will be created
  3. Import the URDF using the URDF Importer dialog: The import should finish successfully
  4. Note the modification date for the .prefab files created for the .stl mesh files.
  5. Reimport the URDF using the URDF Importer dialog with the "Overwrite Existing Prefabs" Option unchecked: The .prefab files for the .stl mesh files should not have been modified.
  6. Reimport the URDF using the URDF Importer dialog with the "Overwrite Existing Prefabs" Option checked: The .prefab files for the .stl mesh files should have been modified.

    Unit tests:

    • StlPostprocess_NewStl_DontCreatePrefab()
    • AssetExists_False()
    • AssetExists_True()

Test Configuration:

Checklist

Other comments