This PR updated UrdfJoint.cs to correct an issue with the IsRevoluteOrContinuous var that previously only checked if the joint was a Revolute
Useful links (GitHub issues, JIRA tickets, forum threads, etc.)
None
Types of change(s)
[x] Bug fix
[ ] New feature
[ ] Code refactor
[ ] Documentation update
[ ] Other (please describe)
Testing and Verification
Please describe the tests that you ran to verify your changes. Please also provide instructions, ROS packages, and Unity project files as appropriate so we can reproduce the test environment.
Test Configuration:
Unity Version: Unity 2021.2.1
Unity machine OS + version: Arch Linux
ROS machine OS + version: Ubuntu 18.04
ROS–Unity communication: Docker
Checklist
[x] Ensured this PR is up-to-date with the dev branch
Seems like a simple fix, the previous version didn't really make sense? To be fair I'm not quite sure what this file is for, I'm just using it to publish joint data back to ROS in my own script (I needed the joint name, which was stored on each Articulation Body in this component).
Proposed change(s)
Copied from PR https://github.com/Unity-Technologies/URDF-Importer/pull/158
This PR updated UrdfJoint.cs to correct an issue with the
IsRevoluteOrContinuous
var that previously only checked if the joint was aRevolute
Useful links (GitHub issues, JIRA tickets, forum threads, etc.)
None
Types of change(s)
Testing and Verification
Please describe the tests that you ran to verify your changes. Please also provide instructions, ROS packages, and Unity project files as appropriate so we can reproduce the test environment.
Test Configuration:
Checklist
dev
branchdev
branchOther comments
Seems like a simple fix, the previous version didn't really make sense? To be fair I'm not quite sure what this file is for, I'm just using it to publish joint data back to ROS in my own script (I needed the joint name, which was stored on each Articulation Body in this component).