Unity-Technologies / URDF-Importer

URDF importer
Apache License 2.0
232 stars 71 forks source link

AIRO-1504 Fix IsRevoluteOrContinuous in UrdfJoint.cs #159

Closed peifeng-unity closed 2 years ago

peifeng-unity commented 3 years ago

Proposed change(s)

Copied from PR https://github.com/Unity-Technologies/URDF-Importer/pull/158

This PR updated UrdfJoint.cs to correct an issue with the IsRevoluteOrContinuous var that previously only checked if the joint was a Revolute

Useful links (GitHub issues, JIRA tickets, forum threads, etc.)

None

Types of change(s)

Testing and Verification

Please describe the tests that you ran to verify your changes. Please also provide instructions, ROS packages, and Unity project files as appropriate so we can reproduce the test environment.

Test Configuration:

Checklist

Other comments

Seems like a simple fix, the previous version didn't really make sense? To be fair I'm not quite sure what this file is for, I'm just using it to publish joint data back to ROS in my own script (I needed the joint name, which was stored on each Articulation Body in this component).

vidurvij-Unity commented 2 years ago

This pull request is not needed because we plan to remove the rigid body support in URDF importer.