Unity-Technologies / URDF-Importer

URDF importer
Apache License 2.0
232 stars 71 forks source link

AIRO-1692 AIRO-1706 Retuning correct axis information #187

Closed vidurvij-Unity closed 2 years ago

vidurvij-Unity commented 2 years ago

Proposed change(s)

Correcting axis export bug fix

Useful links (GitHub issues, JIRA tickets, forum threads, etc.)

https://github.com/Unity-Technologies/URDF-Importer/issues/170 https://github.com/Unity-Technologies/URDF-Importer/issues/185

Types of change(s)

Testing and Verification

Please describe the tests that you ran to verify your changes. Please also provide instructions, ROS packages, and Unity project files as appropriate so we can reproduce the test environment.

Test Configuration:

Checklist

Other comments

albertJkt commented 2 years ago

I've tested these changes locally using our Forklift project - axis information is exported and then reimported properly there.

1 concern that is left regarding this PR (was also mentioned by Anthony) is why GetAxisData() was removed from the base class?