Unity-Technologies / URDF-Importer

URDF importer
Apache License 2.0
214 stars 71 forks source link

AIRO-1796 Change API used to set and query maximum, velocity of a joint. #190

Open vidurvij-Unity opened 2 years ago

vidurvij-Unity commented 2 years ago

Proposed change(s)

Useful links (GitHub issues, JIRA tickets, forum threads, etc.)

https://github.com/Unity-Technologies/URDF-Importer/issues/189

Types of change(s)

Testing and Verification

Please describe the tests that you ran to verify your changes. Please also provide instructions, ROS packages, and Unity project files as appropriate so we can reproduce the test environment.

Test Configuration:

Checklist

Other comments

vidurvij-Unity commented 2 years ago

@K-Tone One of the test is failing. It is down to the fact that I am not able to set this during editorMode. Is this intended or a bug ?

unity-cla-assistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.