Unity-Technologies / URDF-Importer

URDF importer
Apache License 2.0
232 stars 71 forks source link

AIRO-0000 Remove the UNITY_2020_1_OR_NEWER & UNITY_2020_1 defines #191

Closed K-Tone closed 2 years ago

K-Tone commented 2 years ago

... and paths leading to them. We have ArticulationBody support in any Unity release since 20.3 LTS, no one in robotics should be using the Rigidbody path instead.

This is a preliminary PR, intended to land after discussion with Vidur.

Proposed change(s)

Describe the changes made in this PR.

Useful links (GitHub issues, JIRA tickets, forum threads, etc.)

Provide any relevant links here.

Types of change(s)

Testing and Verification

Please describe the tests that you ran to verify your changes. Please also provide instructions, ROS packages, and Unity project files as appropriate so we can reproduce the test environment.

Test Configuration:

Checklist

Other comments

unity-cla-assistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

JuozasK commented 2 years ago

One thing I just noticed, URDF Robot script still says "All rigidbodies" in the editor. We should rename that to "All Articulation bodies"

image
vidurvij-Unity commented 2 years ago

Please add the relevant jira ticket in the description of the pull request.

K-Tone commented 2 years ago

Jira link: https://jira.unity3d.com/browse/PHYS-135