AIRO-1946 URDFInertial behavior bugfix

Unity-Technologies / URDF-Importer

URDF importer

Apache License 2.0

214 stars 71 forks source link

AIRO-1946 URDFInertial behavior bugfix #204

Closed at669 closed 2 years ago

at669 commented 2 years ago

Proposed change(s)

A follow-up to #195; fixes setting of the initial values on the UrdfInertial component and maintains changes between Edit and PlayModes by updating Origin to be Serializable, + override value setting bugfix I was running into while testing.

Types of change(s)

[x] Bug fix

Checklist

[x] Ensured this PR is up-to-date with the dev branch
[x] Created this PR to target the dev branch
[x] Updated the Changelog and described changes in the Unreleased section

mrpropellers commented 2 years ago

Couldn't find anything particularly wrong. Looks to be a re-iteration of the previous fix?

I had to revert the original fix because my original submission had a bug that caused URDF Inertial to initialize with bad values the first time a user attempted to use this feature. So yeah most of the diff is the same as the original, but with Amanda's fixes.