Unity-Technologies / URDF-Importer

URDF importer
Apache License 2.0
232 stars 71 forks source link

Exclude AssimpNet/win DLLs from WebGL builds #220

Open ychaparov opened 1 year ago

ychaparov commented 1 year ago

Proposed change(s)

In the same Unity project, we use URDF-Importer in Unity Editor, but we also have scenes that should be built for WebGL.

As noted in https://github.com/Unity-Technologies/URDF-Importer/issues/201 WebGL builds of a project that has URDF-Importer package always fail, even if URDF-Importer is not used during runtime.

This commit marks the conflicting plugins to exclude WebGL. NOTE: URDF-Importer scripts will not be usable in WebGL builds: Runtime/Unity.Robotics.URDFImporter.asmdef still excludes WebGL. This change allows scenes that don't use URDF-Importer to build.

Useful links (GitHub issues, JIRA tickets, forum threads, etc.)

https://github.com/Unity-Technologies/URDF-Importer/issues/201

Types of change(s)

Testing and Verification

Build a scene that doesn't use URDF-Importer runtime components, while the Unity project has URDF-Importer package

Test Configuration:

Checklist

Other comments

unity-cla-assistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.