Unity-Technologies / URDF-Importer

URDF importer
Apache License 2.0
230 stars 71 forks source link

Geometry, GeometryCollision Tests #95

Closed at669 closed 3 years ago

at669 commented 3 years ago

Proposed change(s)

Introduces tests for runtime classes UrdfGeometry and UrdfGeometryCollision.

Useful links (GitHub issues, JIRA tickets, forum threads, etc.)

AIRO-671

Types of change(s)

Testing and Verification

Creating Unit tests.

Test Configuration:

Checklist

peifeng-unity commented 3 years ago

In addition, would you mind increasing the criteria of the test coverage in Yamato, e.g. increase it to 6% likeif [[ $linecoverage < 6 ]]; then exit 1; fi

peifeng-unity commented 3 years ago

Looks like there are a few methods that are not tested in the Geometry and GeometryCollision. Are you planning to add them in the future PRs?

at669 commented 3 years ago

@peifeng-unity: Looks like there are a few methods that are not tested in the Geometry and GeometryCollision. Are you planning to add them in the future PRs?

most of the ones I didn't cover revolve around importing a mesh, with a valid info from an XML node or from file--personally thought it might fit more with integration testing or down-the-line testing since this doesn't currently include URDF files, but i am open to suggestions!