search

Unity-Technologies / UnityRenderStreaming

Streaming server for Unity
Other
1.3k stars 358 forks source link

[BUG]: The function call for "sendCandidate" in the Signaling / WebSocketSignaling has a different parameter order #979

Open matt-knowles-level-ex opened 7 months ago

matt-knowles-level-ex commented 7 months ago

Package version

3.1.0-exp.8

Environment

* OS:Any
* Unity version:Any
* Graphics API: Any
* Browser: Any

This is a logical issue with the code.

Steps To Reproduce

  1. In "signaling.js" you have a "Signaling" class and "WebSocketSignaling" class each with its own "sendCandidate" function definition
  2. Notice on the "Signaling" class the sendCandidate signature is "sendCandidate(candidate, sdpMid, sdpMLineIndex) { "
  3. Notice on the "WebSocketSignaling" class the sendCandidate signature is "sendCandidate(candidate, sdpMLineIndex, sdpMid) { "

  4. In "video-player.js" it calls the signaling variable with the "sdpMid" first no matter what signaling object is used:

    _this.signaling.sendCandidate(e.candidate.candidate, e.candidate.sdpMid, e.candidate.sdpMLineIndex);

We noticed connection issues on the latest IOS17 update and this was part of the issue we fixed.

Current Behavior

No response

Expected Behavior

Reorder the parameters in the WebSocketSignaling to fix the issue.

Anything else?

No response