search

Unity-Technologies / VisualEffectGraph-Samples

Visual Effect Graph - Samples Project
Other
1.89k stars 392 forks source link

Opening VFX files breaks the demos #1

Closed brnkhy closed 3 years ago

brnkhy commented 5 years ago

Hello, I just downloaded Samples 4.9 Preview rev1 and having a little problems. Samples run fine initially but as soon as I open VFX files in the vfx editor, they are permanently broken. I guess editor overrides some parameters or something on window initialization or something?

In example, voxel terrain demo looks like this after loading graph; unity_2019-02-07_17-20-49

Genie unity_2019-02-07_17-22-08

Radar; unity_2019-02-07_17-25-04

I'm using 2018.3.3f1 Visual Effect Graph 4.9.0

brnkhy commented 5 years ago

I think this is happening because of encoding (Turkish local by the way) as soon as I open a vfx file on editor, bunch of changes like below happens and of course breaks the vfx; tortoisegitmerge_2019-02-07_19-22-02 capital i and I are different chars in Turkish so I suspect that's the problem. Little strange though PARTICLEID becomes PART\u0130CLEID so first I changes to \u0130 but not the second one.

Edit; PARTICLEID was just one example, there's a bunch of those like POSITION in there.

peeweek commented 5 years ago

Yes indeed, actually more a general unity3d / vfx graph issue that should be reported using the bug reporter (Menu Help/Report a bug).

This is an issue we already addressed and as you said, due to some locale encoding (turkish among others). It should be fixed in the future.

I will keep this issue open and once we have a fix push an update of this project so you can confirm it fixed.

brnkhy commented 5 years ago

thanks a lot for the response @peeweek! I'm really looking forward to play with new samples.