Unity-Technologies / arfoundation-samples

Example content for Unity projects based on AR Foundation
Other
3.07k stars 1.15k forks source link

[Bug] SimpleAR is using a different interaction scheme than other samples #542

Closed hybridherbst closed 4 years ago

hybridherbst commented 4 years ago

Describe the bug The Simple AR example scene has an ifdef for Unity Editor and then only reacts to mouse input, not touches. This breaks a) touchscreens on Desktop devices b) frameworks that simulate touches in Unity, and all other samples behave properly (don't have such "editor-hacks").

Would be great if you can remove that ifdef; it's not good practice anyways and seems to be there just so the first scene works with the mouse in editor? At least touches should not be excluded, if you must keep that mouse fallback.

To Reproduce

Expected behavior Cube is placed

Actual behavior Nothing happens because the ifdef guards against the touch input

tdmowrer commented 4 years ago

Thanks for pointing this out. We'll look at making this more consistent.

mdurand42 commented 4 years ago

@tropicdragon Addressed this in the following change: https://github.com/Unity-Technologies/arfoundation-samples/commit/e8cc924b12262ac505c6d3bc074e3dcb342f6b4a

hybridherbst commented 4 years ago

🙏 Thank you!