Unity-Technologies / arfoundation-samples

Example content for Unity projects based on AR Foundation
Other
3.02k stars 1.12k forks source link

Is MakeContentAppearAt removed on ARFoundation 5.0 #950

Closed Phantomxm2021 closed 2 years ago

Phantomxm2021 commented 2 years ago

I'm upgrade from 4.2 version of ARFoundation to 5.0, but I can not found MakeContentAppearAt API. Has it been removed?

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

andyb-unity commented 2 years ago

MakeContentAppearAt has been removed in AR Foundation 5, but in a subsequent patch we'll update our Migration Guide with better assistance for users upgrading a project from version 4.x

Phantomxm2021 commented 2 years ago

MakeContentAppearAt has been removed in AR Foundation 5, but in a subsequent patch we'll update our Migration Guide with better assistance for users upgrading a project from version 4.x

Thank you for your reply.

makakaorg commented 2 years ago

MakeContentAppearAt has been removed in AR Foundation 5, but in a subsequent patch we'll update our Migration Guide with better assistance for users upgrading a project from version 4.x

I can't find any notice here . When you plan to update it?

ankur-unity commented 2 years ago

The docs will be updated with the release of the next 5.0.0 pre-release version update. It's under QA right now. We will update this thread when it's out and the docs are updated.

ankur-unity commented 2 years ago

We have updated our docs to provide a migration guide for this API.

https://docs.unity3d.com/Packages/com.unity.xr.arfoundation@5.0/manual/migration-guide-5-x.html#removal-of-arsessionoriginmakecontentappearathttpsdocsunity3dcompackagescomunityxrarfoundation42apiunityenginexrarfoundationarsessionoriginhtmlunityenginexrarfoundationarsessionoriginmakecontentappearatunityenginetransformunityenginequaternion

ankur-unity commented 2 years ago

Closing this as resolved. Feel free to re-open if there are more questions.

Tommy-Elliott commented 1 year ago

https://docs.unity3d.com/Packages/com.unity.xr.arfoundation@5.0/manual/version-history/migration-guide-5-x.html#removal-of-arsessionoriginmakecontentappearathttpsdocsunity3dcompackagescomunityxrarfoundation42apiunityenginexrarfoundationarsessionoriginhtmlunityenginexrarfoundationarsessionoriginmakecontentappearatunityenginetransformunityenginequaternion

The updated link (added /version-history in the url).

makakaorg commented 1 year ago

File missed. Link is not working: https://github.com/Unity-Technologies/arfoundation-samples/blob/main/Assets/Scripts/XROriginExtensions.cs

Please provide the file.

ulrikdamm commented 9 months ago

This is the correct link (working as of November 2023): https://github.com/Unity-Technologies/arfoundation-samples/blob/main/Assets/Scripts/Runtime/XROriginExtensions.cs