search

Unity-Technologies / arfoundation-samples

Example content for Unity projects based on AR Foundation
Other
3.02k stars 1.12k forks source link

Please remove the #if !UNITY_EDITOR defines from the ARBackgroundRendererFeature.cs #961

Closed KyryloKuzyk closed 2 years ago

KyryloKuzyk commented 2 years ago

Hi AR Foundation team! I'm a developer of the AR Foundation Remove plugin and I have a feature request.

Is your feature request related to a problem? Please describe. The ARBackgroundRendererFeature.cs script contains several #if !UNITY_EDITOR defines that prevent the script from working in the Editor.

Describe the solution you'd like Remove the #if !UNITY_EDITOR defines from the script. Nothing else prevents the script from working perfectly fine in the Editor.

Describe alternatives you've considered Currently, I have to ask my customers to embed the AR Foundation package so my plugin can automatically remove the defines. It would be great if AR Foundation can work out of the box in the Editor.

Thanks in advance!

andyb-unity commented 2 years ago

Resolved in AR Foundation 5.0.0-pre.12. https://docs.unity3d.com/Packages/com.unity.xr.arfoundation@5.0/changelog/CHANGELOG.html