Unity-Technologies / com.unity.mobile.notifications

Mobile Notifications Package
https://docs.unity3d.com/Packages/com.unity.mobile.notifications@2.1/manual/index.html
Other
131 stars 42 forks source link

Refactor Android to use .androidlib #285

Closed aurimasc closed 11 months ago

aurimasc commented 1 year ago

https://jira.unity3d.com/browse/PLAT-6611 Modify Android setup to use .androidlib instead of loose .java files. There are multiple benefits from this:

Testing:

IGuscin commented 11 months ago

Now works a bit better, thanks. Tested that with latest changes mobileNotifications uses the same buildTools as unityLibrary and compileSDK either 33 (if unityLibrary uses lower version) or the same as unityLibrary. Initial problem, when user is missing SDK 33 and targets lower version still exists, but current approach is much better and user friendly. Also, noticed not PR related issue: Editor doesn't suggest to install missing SDK if a higher version is installed. For example install SDK 34 and then try targeting SDK 33 (not installed yet). Build will just fail with missing SDK error