2.0.0-exp2 Distributed Authority has some undue GC every frame

[Yoraiz0r]

Description

In NGO 2.0.0-exp2, simply enabling "distributed authority" in the network manager's session mode results in garbage allocation every frame.

The issue occurs under NetworkSpawnManager.DeferredDespawnUpdate, due to closure of currentTick near the end of the method.

Reproduce Steps

1. Create a blank scene with NGO version 2.0.0exp2
2. Add a network manager, and set its session mode to "distributed authority"
3. Enter playmode
4. Open the profiler and witness that the GC per frame is "20"
5. Exit playmode
6. Change the network manager's session mode to "client server"
7. Enter playmode
8. Witness that GC per frame is "0"

Actual Outcome

GC per frame with distributed authority is 20

Expected Outcome

GC per frame with distributed authority is 0

Environment

• OS: Windows 10
• Unity Version: 6000.0.0b13
• Netcode Version: 2.0.0-exp2
• Netcode Commit: e7ac3c896eea828bced614363711b80dcad4d570

Fixing this

Change the following code from this:

            var despawnObjects = DeferredDespawnObjects.Where((c) => c.TickToDespawn < currentTick).ToList();
            foreach (var deferredObjectEntry in despawnObjects)
            {

To this:

            foreach (var deferredObjectEntry in DeferredDespawnObjects)
            {
                if (deferredObjectEntry.TickToDespawn >= currentTick)
                {
                    continue;
                }