Unity-Technologies / com.unity.netcode.gameobjects

Netcode for GameObjects is a high-level netcode SDK that provides networking capabilities to GameObject/MonoBehaviour workflows within Unity and sits on top of underlying transport layer.
MIT License
2.1k stars 430 forks source link

fix: Fix for NullReferenceException during client Shutdown #2921

Closed samlucas-unity closed 1 month ago

samlucas-unity commented 1 month ago

Upon shutdown the CustomMessagingManager is nulled before ConnectionManager.Shutdown(); is called. This can cause a crash if there are unprocessed messages left in the queue since they can try and access CustomMessagingManager.

fix: Fixed issue with shutdown order causing a crash when unprocessed messages are still in the queue. [MTT-8367]

Changelog

Testing and Documentation

unity-cla-assistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.