chore: Ensure lengths are always written as uint

Unity-Technologies / com.unity.netcode.gameobjects

Netcode for GameObjects is a high-level netcode SDK that provides networking capabilities to GameObject/MonoBehaviour workflows within Unity and sits on top of underlying transport layer.

MIT License

2.1k stars 430 forks source link

chore: Ensure lengths are always written as uint #2945

Closed EmandM closed 3 weeks ago

EmandM commented 3 weeks ago

In order to unserialize and manage network variables on CMB, we need to know the type of values being serialized inside C#. This PR adds some helper logic to ensure that lengths are getting serialized with a consistent type.

MPSNGM-274

Changelog

Ensure that the length of items is always serialized as a uint.
Add a check before casting for safe reading and writing.

Testing and Documentation

All existing tests are passing

unity-cla-assistant commented 3 weeks ago

All committers have signed the CLA.

fluong6 commented 3 weeks ago

Hi @EmandM , NGO release 2.0.0-exp5 is already released. for new ngo-2.0.0, you can base it off develop-2.0.0 branch

EmandM commented 3 weeks ago

Closing and moving to the correct branch