search

Unity-Technologies / com.unity.netcode.gameobjects

Netcode for GameObjects is a high-level netcode SDK that provides networking capabilities to GameObject/MonoBehaviour workflows within Unity and sits on top of underlying transport layer.
MIT License
2.15k stars 435 forks source link

v1.3.0 MLAPIEditor.cs script from MLAPI_Installer does not compile due to missing dependencies #68

Closed MarcBritton closed 6 years ago

MarcBritton commented 6 years ago

Issue Type

Bug

Description

The Getting Started wiki page says the easiest way to get started is to download the MLAPI_Installer.unitypackage from the releases page. I downloaded the latest version which is v1.3.0.

When I import the package a compile error is displayed: "Assets/Editor/MLAPI/MLAPIEditor.cs(9,13): error CS0246: The type or namespace name `GithubRelease' could not be found. Are you missing an assembly reference?"

The offending line is:

    private GithubRelease[] releases = new GithubRelease[0];

GithubRelease is undefined at this point.

I then downloaded the previous release v1.2.2, which contains additional JSON/GithubAsset.cs and JSON/GithubRelease.cs files which aren't in the v1.3.0 version. The installer then compiles and works fine.

Expected Behavior

MLAPI_Installer.unitypackage should be self contained and not depend on files in previous versions.

Actual Behavior

Must use files from previous release.

TwoTenPvP commented 6 years ago

This has been resolved. I had forgotten to include those structures in the latest version of the installer. The release has been updated.