Rewrite SelectionsGroupsWindow to use UIToolkit

MechWarrior99 commented 2 years ago

Description

Unity has made it pretty clear that UIToolkit is the future for the editor with many existing and new tools/windows using it instead of IMGUI. As Selection Groups is a newer package still in preview and in flux, it seems to me that it would be good to rewrite it now instead of later to use UIToolkit.

Advantages

UIToolkit comes with a number of advantages over IMGUI.

It is much easier and quicker to do any sort of styling.
It is a lot easier to make more responsive feeling UI with hover states and such.
It is easy to make a performant list view like what is used to show groups in SG.
It allows for third parties to customize the window.
It is the more modern UI system that will be used more and more in the future.
Cleaner window code than what is currently there.

Disadvantages

There are very few disadvantages to switching to UITK

You would have to maintain and use UITK for future development. This is only a disadvantage if you are not familiar with or don't like UITK in my opinion.
Takes work to review the rewrite, or do the rewrite yourself.

Conclusion

I would be happy to do the rewrite myself. I have done extensive work with UIToolkit, and editor scripting and this is a fairly simply(comparatively) system to create/rewrite.

Basically, if you are willing to switch to UITK I will do all of the work for it you.

sindharta commented 2 years ago

Let me get back to you soon on this.

sindharta commented 2 years ago

Thank you very much for the offer. Moving to UIToolkit is something that we had planned to do at some point, but it's not a high priority item for us, so at the moment we don't know when we can allocate our time to implement it ourselves.

So yes, it would be great if you can help rewriting the code and let us review it later.

MechWarrior99 commented 2 years ago

Glad to hear! I will see what(and when) I can do!

Unity-Technologies / com.unity.selection-groups