Unity-Technologies / com.unity.webrtc

WebRTC package for Unity
Other
738 stars 186 forks source link

rebase experimental webgl to recent main #1012

Closed Thaina closed 6 months ago

unity-cla-assistant commented 6 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
8 out of 9 committers have signed the CLA.

:white_check_mark: aet
:white_check_mark: lsei
:white_check_mark: kannan-xiao4
:white_check_mark: lumin-leaper
:white_check_mark: MaximKurbanov
:white_check_mark: Thaina
:white_check_mark: elic-sightful
:white_check_mark: DannisMa
:x: florence-rolland
You have signed the CLA already but the status is still pending? Let us recheck it.

karasusan commented 6 months ago

@Thaina There are many conflicts in this PR. Can I remove the old branch and replace new one?

Thaina commented 6 months ago

@Thaina There are many conflicts in this PR. Can I remove the old branch and replace new one?

Yes, I don't know why it conflicted but I had rebase and fix everything to have no conflict in my branch

karasusan commented 6 months ago

@Thaina There are many conflicts in this PR. Can I remove the old branch and replace new one?

Yes, I don't know why it conflicted but I had rebase and fix everything to have no conflict in my branch

@Thaina OK, I'm removing a old one and replacing a new one.

karasusan commented 6 months ago

done https://github.com/Unity-Technologies/com.unity.webrtc/tree/thaina/experimental/webgl-platform