search

Unity-Technologies / com.unity.webrtc

WebRTC package for Unity
Other
738 stars 186 forks source link

Update BuildProcessor to support Android x86_64 #1026

Open Babilinski opened 2 months ago

Babilinski commented 2 months ago

Updated the Build Processor script to prevent logging a warning when building for Android x86_64 architecture since it is now supported.

unity-cla-assistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

karasusan commented 2 months ago

Thank you for the contribution! It looks no problem. I'm only curious about contents of the log when the Android architecture is not supported.

Debug.LogWarning(
                    $"WebRTC apps require a target architecture to be set {RequiredAndroidArchitectures}. " +
                    $"Currently set to {PlayerSettings.Android.targetArchitectures}");
Babilinski commented 2 months ago

Ahh I see, the warning would log the following message:

"WebRTC apps require a target architecture to be set ARM64, X86_64. Currently set to X86_64"

How do you feel about updating the wording to log this message instead?

"WebRTC apps are only supported on the following CPU architectures: ARM64, X86_64. Current target architecture set to: X86_64"

By changing the code to : 

Debug.LogWarning(
            $"WebRTC apps are only supported on the following CPU architectures: {RequiredAndroidArchitectures}. " +
            $"Current target architecture set to: {PlayerSettings.Android.targetArchitectures}");