Unity-Technologies / com.unity.webrtc

WebRTC package for Unity
Other
753 stars 191 forks source link

fix: Fix crash when streaming video between different platforms #793

Closed karasusan closed 2 years ago

karasusan commented 2 years ago

This pull request fixes the crash bug when streaming video between peers on macOS and Windows.

This crash occurs the difference of the "codec implementation" property in the SdpVideoFormat parameter. SdpVideoFormat, the argument of FindCodecFactory function comes from another peer to negotiate available media codecs. The parameter "codec implementation" is used for determine codec, however, This determination process is wrong. It must be determined with the codec mimetype and profiles, not codec implementation.

We will release the hotfix version because this bug affects many users.