Unity-Technologies / com.unity.webrtc

WebRTC package for Unity
Other
739 stars 185 forks source link

CI: Switch images used for running CI jobs #870

Closed rasmus-unity closed 9 months ago

rasmus-unity commented 1 year ago

What

Changing images used in CI jobs

Why

The katana-to-yamato/* images previously used will likely be deprecated at some point, so let's just have you now move to images which will be maintained going forward.

Dependencies

None

Note to reviewers

Looks like relevant CI jobs has been started automatically, hope I have covered everything

rasmus-unity commented 1 year ago

Hi @karasusan, given the failing jobs, I guess we shouldn't merge this PR. Tried to look at what the scripts are doing, but couldn't immediately figure out, so I let you handle it from here 🙂 (Not super familiar with package building, but haven't seen other packages needing to copy files around like this in CI jobs, so perhaps it could be done in a different way?)

In any case, feel free to reach out if there is anything I can help with. The current katana-to-yamato/* images will likely live for a couple of more months at least, so this is not urgent.

florence-rolland commented 11 months ago

Hey @karasusan - it is important that this PR is merged! We are getting rid of katana-to-yamato images now, and sooner or later you will be unable to run your tests

rasmus-unity commented 9 months ago

@karasusan, just to make sure that you are aware that eventually those katana-to-yamato images will be deprecated and stop working 🙂