search

Unity-Technologies / com.unity.webrtc

WebRTC package for Unity
Other
739 stars 185 forks source link

[BUG]: XCODE 14.2 iOS/webrtc.framework/webrtc' does not contain bitcode. #873

Closed CalvadosHof closed 1 year ago

CalvadosHof commented 1 year ago

Package version

3.0.0-pre.3

Environment

* OS:iOS
* Unity version:2020.3.19R1

Steps To Reproduce

  1. XCODE compile with Enable Bitcode = OFF, !!!
  2. Get Error as following
  3. '/Users/furuyama.kazuo/Downloads/iOS-3/Frameworks/com.unity.webrtc/Runtime/Plugins/iOS/webrtc.framework/webrtc' does not contain bitcode. You must rebuild it with bitcode enabled (Xcode setting ENABLE_BITCODE), obtain an updated library from the vendor, or disable bitcode for this target. file '/Users/furuyama.kazuo/Downloads/iOS-3/Frameworks/com.unity.webrtc/Runtime/Plugins/iOS/webrtc.framework/webrtc' for architecture arm64

Current Behavior

Just Getting Build Error on X Code 14. Previous X Code 13 has no problem.

I feel this program is same as following. Issue 13925: Apple rejects apps with bitcode and WebRTC compiled with Chromium toolchain https://bugs.chromium.org/p/webrtc/issues/detail?id=13925

Expected Behavior

Please rebuild webrtc.framework with no Bit Code version webrtc component.

Anything else?

No response

karasusan commented 1 year ago

We disabled bitcode support this PR. https://github.com/Unity-Technologies/com.unity.webrtc/pull/842/files#diff-0000a7afc06579bad6cefe1924c8720897bcfb254093b677d5b8febef2cb3025L56

Because bitcode is deprecated since XCode 14. https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes

The better solution might be that Unity exports xcode project which disables bitcode. Any idea?

karasusan commented 1 year ago

@CalvadosHof I guess you change bitcode option for one part of xcode project. You need to change bitcode option all in xcode project.

CalvadosHof commented 1 year ago

Thank you for your information, it is well-known information. But I believe those information is just "Bitcode is unrecomend", and "Bit code still supported by Xcode for iOS Application".

Therefore, I marked as following, may be this setting is all of related Bitcode. Enable BitCode No Debug No Release No ReleaseForProfiling No ReleaseForRunni9ng No, But I get Error from Xcode14.2 as following. This situation is save as Xcode14, Xcode14.01, Xcode14.1.

  1. '/Users/furuyama.kazuo/Downloads/iOS-3/Frameworks/com.unity.webrtc/Runtime/Plugins/iOS/webrtc.framework/webrtc' does not contain bitcode. You must rebuild it with bitcode enabled (Xcode setting ENABLE_BITCODE), obtain an updated library from the vendor, or disable bitcode for this target. file '/Users/furuyama.kazuo/Downloads/iOS-3/Frameworks/com.unity.webrtc/Runtime/Plugins/iOS/webrtc.framework/webrtc' for architecture arm64

Case of iOS16, the previous version of iOS Application is unstable, it is crash in a short time, because I wish load module by Xcode 14 with WebRTC & AWS Components.

I would like to know if anyone has successfully compiled an iOS14 Unity Application with webRTC+AWS on Xcode14.x.

2023年1月17日(火) 11:48 Kazuki Matsumoto @.***>:

@CalvadosHof https://github.com/CalvadosHof I guess you change bitcode option for one part of xcode project. You need to change bitcode option all in xcode project.

— Reply to this email directly, view it on GitHub https://github.com/Unity-Technologies/com.unity.webrtc/issues/873#issuecomment-1384768204, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKPZXH7HES5B4BNZG6KCZFDWSYB57ANCNFSM6AAAAAATY5UKOI . You are receiving this because you were mentioned.Message ID: @.***>

-- 古山 一夫

karasusan commented 1 year ago

I tested building iOS app on Xcode 14.2, it is succeeded. I turned Enable Bitcode off in the Build Options.
Anything I’m missing?

Pasted_Image_2023_01_18_10_48
CalvadosHof commented 1 year ago

Thank you for your testing, Could you inform detail about your test code, because I seem to have very few build step counts.

2023年1月18日(水) 10:53 Kazuki Matsumoto @.***>:

I tested building iOS app on Xcode 14.2, it is succeeded. I turned Enable Bitcode off in the Build Options. Anything I’m missing?

[image: Pasted_Image_2023_01_18_10_48] https://user-images.githubusercontent.com/1132081/213061320-b67d4f00-0a40-47b5-9c75-5d242edeb98d.png

— Reply to this email directly, view it on GitHub https://github.com/Unity-Technologies/com.unity.webrtc/issues/873#issuecomment-1386352420, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKPZXH4PNC3NYTGFO5HGD7TWS5EKLANCNFSM6AAAAAATY5UKOI . You are receiving this because you were mentioned.Message ID: @.***>

-- 古山 一夫

karasusan commented 1 year ago

You can import an package sample from Package Manager. Please see below. https://docs.unity3d.com/Packages/com.unity.webrtc@3.0/manual/sample.html

CalvadosHof commented 1 year ago

Thanks, I'll check it out.

2023年1月18日(水) 13:10 Kazuki Matsumoto @.***>:

You can import an package sample from Package Manager. Please see below. @.***/manual/sample.html

— Reply to this email directly, view it on GitHub https://github.com/Unity-Technologies/com.unity.webrtc/issues/873#issuecomment-1386458782, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKPZXH56AQEHYV4SYYWHPPDWS5UKDANCNFSM6AAAAAATY5UKOI . You are receiving this because you were mentioned.Message ID: @.***>

-- 古山 一夫

karasusan commented 1 year ago

@CalvadosHof Have you solved your issue?

CalvadosHof commented 1 year ago

Thank you for your response.

Sorry, Currntly still checking problem situation, because sample sdk has no problem, but in my project stile has problem. My project is upgraded from old system it integrate with WebRTC and AWS-SDK, I can found lot of difference on WebRTC and AWS-SDK, I searching real problem. Because Unity .net core change to .net core standard2.0, WebRTC changed, AWD SDK change base version2 to version3... If I find a real problem about this I will respond.

the Problem on my project, it solved by the new Apple Xcode with my old version of Unity iOS output, therefore it's a tentative workaround. But I will definitely resolve this issue as I can't leave the upgrade unattended.

2023年1月31日(火) 11:42 Kazuki Matsumoto @.***>:

@CalvadosHof https://github.com/CalvadosHof Have you solved your issue.

— Reply to this email directly, view it on GitHub https://github.com/Unity-Technologies/com.unity.webrtc/issues/873#issuecomment-1409660169, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKPZXH5QQCWKU4WKSPDCMB3WVB3Z5ANCNFSM6AAAAAATY5UKOI . You are receiving this because you were mentioned.Message ID: @.***>

-- 古山 一夫

karasusan commented 1 year ago

@CalvadosHof Thanks for your reply. I understood your trouble. Please let me know if you have any progress.

CalvadosHof commented 1 year ago

Thank you! If I meet the same trouble, I will make a new thread.

2023年2月21日(火) 11:35 Kazuki Matsumoto @.***>:

Closed #873 https://github.com/Unity-Technologies/com.unity.webrtc/issues/873 as completed.

— Reply to this email directly, view it on GitHub https://github.com/Unity-Technologies/com.unity.webrtc/issues/873#event-8566272691, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKPZXH3T3KNMD4UREAAAL2TWYQSVNANCNFSM6AAAAAATY5UKOI . You are receiving this because you were mentioned.Message ID: <Unity-Technologies/com.unity.webrtc/issue/873/issue_event/8566272691@ github.com>

-- 古山 一夫