search

Unity-Technologies / com.unity.webrtc

WebRTC package for Unity
Other
739 stars 185 forks source link

Fix: Fix Crash on dedicated Linux Server #887

Closed ZenBre4ker closed 1 year ago

ZenBre4ker commented 1 year ago

This simple check makes sure that vulkan is actually available and not a nullptr.

It enables dedicated servers to at least run the preload and not crash in the process of running webrtc without graphics initialized. I didnt test yet to which degree webrtc feature works, but the Audio WebRtc Testscene works now without crash.

Fixes #791 in my case at least.

The reason this crashed is that vulkan is not available on dedicated server build and this function returns a nullptr which is not handled: https://github.com/Unity-Technologies/com.unity.webrtc/blob/main/Plugin%7E/WebRTCPlugin/UnityVulkanInterfaceFunctions.cpp#L17

unity-cla-assistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

karasusan commented 1 year ago

It looks no matter for me.