Unity-Technologies / com.unity.webrtc

WebRTC package for Unity
Other
739 stars 185 forks source link

[BUG]: CMAKELists.txt confusion #906

Closed SetoKaiba closed 11 months ago

SetoKaiba commented 1 year ago

Package version

3.0.0-pre.5

Environment

* OS:Windows10
* Unity version:Unity 2021.3

Steps To Reproduce

Load the project with preset x64-windows-msvc in CLion.

Current Behavior

CLion get compiler information will report error. https://youtrack.jetbrains.com/issue/CPP-33217/Reload-CMake-Project-confusion

Expected Behavior

It should not report error.

Anything else?

After a deep dive in the CMakeLists.txt, I found some confusion. Why /Yu /Yc is added without filename here?

https://github.com/Unity-Technologies/com.unity.webrtc/blob/main/Plugin~/WebRTCPlugin/CMakeLists.txt#L125 https://github.com/Unity-Technologies/com.unity.webrtc/blob/main/Plugin~/WebRTCPlugin/CMakeLists.txt#L154

https://github.com/Unity-Technologies/com.unity.webrtc/blob/main/Plugin~/WebRTCPluginTest/CMakeLists.txt#L88 https://github.com/Unity-Technologies/com.unity.webrtc/blob/main/Plugin~/WebRTCPluginTest/CMakeLists.txt#L113

SetoKaiba commented 1 year ago

And also, Unity China accessing to global resource is cut off after it became joint venture. I have no access to Slack now. Is there any way to have an instant messaging with you? If so, you can send me an email to me here. jie.situ@unity.cn

SetoKaiba commented 1 year ago

Change the /Yu /Yupch.h to /Yupch.h and Change the /Yc /Ycpch.h to /Ycpch.h solve the reload cmake project in CLion.

karasusan commented 1 year ago

This is a related issue.

892

kannan-xiao4 commented 1 year ago

memo: WRS-464

SetoKaiba commented 1 year ago

The #892 should fix the problem.