Unity-Technologies / com.unity.webrtc

WebRTC package for Unity
Other
738 stars 185 forks source link

[REQUEST]: Build WebRTC with OpenSSL instead of BoringSSL #951

Open mwben opened 11 months ago

mwben commented 11 months ago

Is your feature request related to a problem?

Hello there, thank you for your amazing work on this WebRTC integration for Unity!

Currently, I am trying to add a WebSocket Plugin (for signaling) to your existing C++ CMakeLists project, but I always get either duplicate symbols errors (when adding OpenSSL) or missing symbols (when relying on BoringSSL symbols) as most of the Websocket libraries rely on OpenSSL, but WebRTC is built with BoringSSL (an OpenSSL fork). So, its symbols are similar, but don't match exactly. See also: https://bugs.chromium.org/p/webrtc/issues/detail?id=10160

"Although BoringSSL is an open source project, it is not intended for general use, as OpenSSL is. We don't recommend that third parties depend upon it. Doing so is likely to be frustrating because there are no guarantees of API or ABI stability."

It's just very frustrating that I've been trying to add Websocket signaling to this project for weeks now just to find out that what we can do with WebRTC native is very limited due to BoringSSL.

Describe the solution you'd like

I see that you are already patching when building WebRTC. Is it possible that you guys either build WebRTC linking towards OpenSSL by default or provide a separate build script that helps doing that (as I'm not deep enough in this topic)?

Describe alternatives you've considered

No response

Additional context

As I consider you guys experts, what are your thoughts and experiences? Did you build WebRTC using OpenSSL before? How hard would it be to do?

karasusan commented 11 months ago

@mwben In this post, some developers tried to use external SSL library, but it looks nonody succeed it. https://groups.google.com/g/discuss-webrtc/c/bxy6DAK_PUk/m/6-9X7PACAgAJ

Unfortunately, I haven't tried these flag rtc_build_ssl and rtc_ssl_root.