search

Unity-Technologies / com.unity.webrtc

WebRTC package for Unity
Other
738 stars 185 forks source link

feat: Add x86_64 to the Android plugin build script #952

Closed lumin-leaper closed 11 months ago

lumin-leaper commented 11 months ago

This is the second pull request to address the feature requested in issue 802: https://github.com/Unity-Technologies/com.unity.webrtc/issues/802

It adds x86_64 as an additional architecture for the Android variant of the plugin. This will build and add the x86_64 binaries while also keeping the existing arm based binaries.

Note: It does not add the new binaries to the plugin per se. The changes will need to be used by the maintainer to generate the new libwebrtc.aar file and commit it.

Legal stuff: “For clarity, in accordance with Item 1 and “Contribution” as defined in the Agreement under which this software is submitted to the Project, this Contribution includes only the contents of the submitted files. Accordingly, external software referenced by this Contribution, including the Android API, are Not a Contribution. Thus, one will appreciate that no license, or other, rights are granted by this Contribution to, or in connection with, any such external software.”

karasusan commented 11 months ago

@lumin-leaper This package is built on our CI pipeline. It works fine on my Android device, but it's not x86_64. Could you try that? https://drive.google.com/file/d/1SxnZMUtOi90WkhDPMhQvqPxIB5jultpN/view?usp=sharing

lumin-leaper commented 11 months ago

Thanks @karasusan . We have tested this and it is working as expected for us.

karasusan commented 11 months ago

@lumin-leaper Thanks a lot!