aet commented 11 months ago

SimulcastEncoderFactory using alternative to https://github.com/Unity-Technologies/com.unity.webrtc/pull/955

Cherry-picked from a branch with lots of other customizations in progress, haven't even tried to compile it against vanilla version. :)

955 has the Simulcast example scene in progress, but I didn't try running it. After rebasing and catching up with latest main, seems to still work for our internal use case.

In addition, we've exposed PC SetBitrate/webrtc::BitrateSettings to C# but things should work without fine-grained control, I can cherry-pick that one in too if interested

aet commented 10 months ago

@karasusan did you try applying this to your branch or if there's any issues with it?

karasusan commented 9 months ago

@aet I checked this PR and works well with few fixes. Can I make a new PR for this? https://github.com/Unity-Technologies/com.unity.webrtc/tree/feat/simulcast-adapter-nvcodec-fix

aet commented 9 months ago

@karasusan sure

karasusan commented 9 months ago

Opened the new PR here. https://github.com/Unity-Technologies/com.unity.webrtc/pull/974

Unity-Technologies / com.unity.webrtc

add SimulcastEncoderFactory and initial simulcast support for NvEncoder #956

955 has the Simulcast example scene in progress, but I didn't try running it. After rebasing and catching up with latest main, seems to still work for our internal use case.