fix: fractional scaling ratio support

Unity-Technologies / com.unity.webrtc

WebRTC package for Unity

Other

738 stars 185 forks source link

Closed aet closed 10 months ago

aet commented 11 months ago

Finished testing of using #930 vs my previous implementation using NPP and noticed a small regression.

It seems scaleResolutionDownBy = 1.5 doesn't quite work, trivial casting issue
~~The image quality is a bit blurry, so I added a lanczos alternative and image quality is now comparable to what I've been using with NPP~~ EDIT: Kernel worked in local testing, but don't have time to debug an issue when running on cloud. For now, I'll just fallback to my old NPP scaling code in internal use

aet commented 11 months ago

@karasusan still testing this, potentially found some issues that could get fixed by porting code from NPP branch, just without use of NPP itself

aet commented 11 months ago

@karasusan ready for review, for now I just left the fractional scaling ratio fix in to play it safe