search

Unity-Technologies / com.unity.webrtc

WebRTC package for Unity
Other
738 stars 185 forks source link

feat: libwebrtc m116 #973

Closed karasusan closed 9 months ago

karasusan commented 9 months ago

The previous update of libwebrtc is here. https://github.com/Unity-Technologies/com.unity.webrtc/pull/960

However, building libwebrtc is failed because of android_toolchain in third_party folder in Chromium. We got the error below.

Traceback (most recent call last):
  File "/home/bokken/build/output/Unity-Technologies/com.unity.webrtc/depot_tools/metrics.py", line 296, in print_notice_and_exit
    yield
  File "/home/bokken/build/output/Unity-Technologies/com.unity.webrtc/depot_tools/gclient.py", line 3770, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/home/bokken/build/output/Unity-Technologies/com.unity.webrtc/depot_tools/gclient.py", line 3756, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/home/bokken/build/output/Unity-Technologies/com.unity.webrtc/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/home/bokken/build/output/Unity-Technologies/com.unity.webrtc/depot_tools/gclient.py", line 3239, in CMDsync
    ret = client.RunOnDeps('update', args)
  File "/home/bokken/build/output/Unity-Technologies/com.unity.webrtc/depot_tools/gclient.py", line 2170, in RunOnDeps
    gclient_scm.scm.GIT.Capture(['checkout', tail], cwd=cwd)
  File "/home/bokken/build/output/Unity-Technologies/com.unity.webrtc/depot_tools/scm.py", line 116, in Capture
    output = subprocess2.check_output(
  File "/home/bokken/build/output/Unity-Technologies/com.unity.webrtc/depot_tools/subprocess2.py", line 255, in check_output
    return check_call_out(args, stdout=PIPE, **kwargs)[0]
  File "/home/bokken/build/output/Unity-Technologies/com.unity.webrtc/depot_tools/subprocess2.py", line 215, in check_call_out
    out, returncode = communicate(args, **kwargs)
  File "/home/bokken/build/output/Unity-Technologies/com.unity.webrtc/depot_tools/subprocess2.py", line 190, in communicate
    proc = Popen(args, **kwargs)
  File "/home/bokken/build/output/Unity-Technologies/com.unity.webrtc/depot_tools/subprocess2.py", line 169, in __init__
    raise OSError('Execution failed with error: %s.\n'
OSError: Execution failed with error: [Errno 2] No such file or directory: '/home/bokken/build/output/Unity-Technologies/com.unity.webrtc/src/third_party/android_toolchain'.
Check that /home/bokken/build/output/Unity-Technologies/com.unity.webrtc/src/third_party/android_toolchain or git exist and have execution permission.

To fix this, we must remove dependencies by android_toolchain or adding the library ourselves. It's easy to imagine this work is troublesome. Therefore we skipped the version M115, and use the next version M116 which has fixed this issue.