Unity-Technologies / ml-agents

The Unity Machine Learning Agents Toolkit (ML-Agents) is an open-source project that enables games and simulations to serve as environments for training intelligent agents using deep reinforcement learning and imitation learning.
https://unity.com/products/machine-learning-agents
Other
17.12k stars 4.15k forks source link

ML-Agents 0.7 (beta) & UWP target #1737

Closed b-fazamb closed 5 years ago

b-fazamb commented 5 years ago

As briefly discussed today in an existing issue (#648 ) there does not seem to be a way to build an UWP target for evaluation of a model. This is despite the replacement of TensorFlowSharp with the new inference engine.

I have attempted using both an IL2CPP config and a Mono. In the first instance there seems to be a dependency not supported in UWP, in the second there is a missing API.

Is this something that can be eventually looked at? This prevents evaluating models on HoloLens and Windows Mixed Reality headsets.

vincentpierre commented 5 years ago

Can you try with this branch release-v0.7-2dll ? This is the current proposed fix. EDIT: Only a fix for UWP IL2CPP

b-fazamb commented 5 years ago

Thank a lot for this @vincentpierre , the fix made the trick! I could build and deploy to HoloLens succesfully for the first time under UWP/IL2CPP. Tested both with the 3D Ball and the Soccer Ball scenes.

The next thing I will start testing is what happens when I start adding all manner of MR components to a scene, but my hunch is that it should be fine. Thanks again for looking into this, and hopefully this fix can make it into 0.7 once it's released?

13Flo commented 5 years ago

I'm encountering issues building with IL2CPP for Android and found that thread. But the link above to the branch containing the fixed dll is broken. Any help would be welcome!

krishnanpc commented 5 years ago

@b-fazamb What versions of Unity and MRTK/Holotoolkit were you using? I was not able to build for il2cpp also.. ANd also curious to know how it turned out, when further MR components were added?

EDIT: I have tried with Unity 2018 with UWP/IL2CPP Backend and is working in build.

b-fazamb commented 5 years ago

Yes, I had built using 2018.3, in fact. MRTK was the latest version before vNext and no extra components had been added.

That was a mere proof of concept, as our main production branch had to be started way earlier than the patch and so prototype turned out to use OpenVR, instead.

However, we plan to go back to it very soon and move to UWP/MRTK, especially once we can get our hands on HoloLens 2 :)

krishnanpc commented 5 years ago

Thank you for writing.

I have also treid a few basic MR elements and it seems to work, but i have just tried the pre trained envs.

b-fazamb commented 5 years ago

A different environment should not make much of a difference, really, in terms of being able to build to an UWP target.

krishnanpc commented 5 years ago

I see, ultimately my Goal is to make some interactive RL (HoloLens info as implicit Feedback for the reward systems) work within this setup. Maybe there are better approaches to solve this, given both ML Agents and HoloLens dev are experimental :)

On Mon, Apr 8, 2019 at 1:12 PM Fabio notifications@github.com wrote:

A different environment should not make much of a difference, really, in terms of being able to build to an UWP target.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Unity-Technologies/ml-agents/issues/1737#issuecomment-480788694, or mute the thread https://github.com/notifications/unsubscribe-auth/ADT3MWbtcTjauJxmWgAkK3nqxJEtgIRoks5veyQjgaJpZM4bGyYj .

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.