'command line arguments' feature does not work

Unity-Technologies / ml-agents

The Unity Machine Learning Agents Toolkit (ML-Agents) is an open-source project that enables games and simulations to serve as environments for training intelligent agents using deep reinforcement learning and imitation learning.

https://unity.com/products/machine-learning-agents

Other

16.93k stars 4.14k forks source link

'command line arguments' feature does not work #2418

Closed Sohojoe closed 4 years ago

Sohojoe commented 5 years ago

Describe the bug The new feature 'support for command line arguments' #2243 does not work

To Reproduce mlagents-learn config/my_config.yaml --train --run-id=my-id --my-custom-opton=value

Environment (please complete the following information):

ML-Agents version: v0.9

Notes / Observations

learn.py does not support options which are not defined in the _USAGE string. Its not clear if docopt supports this.
learn.py does not pass options through to UnityEnvironment via args

ervteng commented 5 years ago

Hi @Sohojoe, big thanks for spotting this issue! It's an error on our part in the release notes - the PR enabled the parameters to be passable when creating a UnityEnvironment class, but it was never intended to pass down through learn.py. We're looking into doing this properly - but basically I would add a parameter to the docopt, turn it into a list of strings, and pass it into the create_environment_factory method in learn.py.

chriselion commented 4 years ago

This is fixed on develop and will be available in the next release. See https://github.com/Unity-Technologies/ml-agents/pull/2594

github-actions[bot] commented 3 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.