search

Unity-Technologies / multiplayer-community-contributions

Community contributions to Unity Multiplayer Networking products and services.
MIT License
429 stars 161 forks source link

Facepunch Transport fix #116

Closed quentinleon closed 2 years ago

quentinleon commented 2 years ago

IConnectionManager.OnMessage created a byte array segment 1 byte too short, which caused clients to not load in, along with the warning: [Netcode] Received a message that claimed a size larger than the packet, ending early! This is most likely a remnant from having to remove the networkChannel byte from the packet in the previous 0.1.0 release of MLAPI.

Additionally, the Transport.Send override had an 'unsafe' buffer copy (again, most likely from having to add the networkChannel byte in a previous release), which is no longer necessary when using a different SendMessage overload from Facepunch's networking solution.

unity-cla-assistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.