Clean up SteamNetworking transports

Unity-Technologies / multiplayer-community-contributions

Community contributions to Unity Multiplayer Networking products and services.

MIT License

421 stars 161 forks source link

Clean up SteamNetworking transports #190

Closed JamesMcGhee closed 1 year ago

JamesMcGhee commented 1 year ago

Removed the legacy now deprecated SteamNetworking transport
Updated the SteamNetworkingSockets transport to remove the implicit constructor as this feature is not available on the version of C# used by Unity 2020 LTS. Replaced that with an explicit constructor for the same net effect.

simon-lemay-unity commented 1 year ago

Instead of removing the deprecated Steam transport entirely, I'd be more inclined to mark it with the Obsolete attribute first. This would give a chance to inform users to update to the new one.

JamesMcGhee commented 1 year ago

@simon-lemay-unity SteamNetworking has been marked Obsolete by Valve for years now

And users tend not to read, since it shouldn't be getting any more updates there is no harm in removing it from the latest version if they really want a previous version this is GitHub they can fetch a previous version

simon-lemay-unity commented 1 year ago

@JamesMcGhee Alright, fair point. Could you remove the transport from the list of supported transports in the README file at the top of the repository before I merge this?

NullSoldier commented 1 year ago

Bumping this as it's pretty close. It just needs to make sure not to leave hanging references to a deleted transport around in the documentation. @JamesMcGhee

JamesMcGhee commented 1 year ago

Sorry didn't see the notification I have updated that I think let me know