Unity-Technologies / multiplayer-community-contributions

Community contributions to Unity Multiplayer Networking products and services.
MIT License
421 stars 161 forks source link

Add option to configure websocket path #198

Closed NullSoldier closed 1 year ago

NullSoldier commented 1 year ago

This path was hardcoded to /netcode which is not necessary for websocket connections, and is an opinionated choice that breaks in certain reverse proxy configurations such as using domains per game server with certs for WSS connections from the browser.

The only way to use the transport in an actual professional setting is to fork and delete the path out of the code, which this lets the user do now without modifying the code.

Web sockets are not required to listen on any path at all. This allows users to delete the path but the default does not break backwards compatibility.

Using this in production for our unity re-write of https://rolltable.app

Screen Shot 2023-01-14 at 4 27 01 PM

unity-cla-assistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

NullSoldier commented 1 year ago

I took this out of draft, it's ready now.