search

Unity-Technologies / multiplayer-community-contributions

Community contributions to Unity Multiplayer Networking products and services.
MIT License
435 stars 163 forks source link

Update Steam Game Server Callbacks #221

Closed JamesMcGhee closed 1 year ago

JamesMcGhee commented 1 year ago

fixes #220

The Callback registration for Steam Game Server was not correct in the case of a headless build. the primary change is that when the build is UNITY_SERVER the CreateGameServer method should be used in place of the Create method for callback registration.

This issue would have only effected users working Steam Game Server builds which is rare but important

JamesMcGhee commented 1 year ago

fixes #220 and any related issues dealing with batch size miss match

brogan89 commented 1 year ago

Can confirm this works for me too. using Netcode 1.4.0. Cheers 🍻

A1win commented 1 year ago

Also seems to work for us on Netcode 1.4.0. On 1.3.1 I noticed some weird stutter in object movement, but I can't tell if it's because of this change or because of an issue in 1.3.1 itself. Without this change I'm unable to test 1.3.1 so can't confirm either way. Probably all that matters is that it works on 1.4.0, though! 👍

westonleavitt commented 1 year ago

fixes 1.4.0 for us. would love to see this pushed