search

Unity-Technologies / obstacle-tower-env

Obstacle Tower Environment
Apache License 2.0
542 stars 125 forks source link

GCP tutorial feedback / minor issues #53

Open Sohojoe opened 5 years ago

Sohojoe commented 5 years ago

From GCP tutorial

  1. [bug] The tutorial references an old release

    wget https://storage.googleapis.com/obstacle-tower-build/v1/obstacletower_v1_linux.zip
unzip obstacletower_v1_linux.zip

    should be 

    wget https://storage.googleapis.com/obstacle-tower-build/v1.1/obstacletower_v1.1_linux.zip
unzip obstacletower_v1.1_linux.zip

  2. [bug] Install the Obstacle Tower Environment is missing cd obstacle-tower-env

    git clone https://github.com/Unity-Technologies/obstacle-tower-env
pip3 install ./ 
cd ../

    should be

    git clone https://github.com/Unity-Technologies/obstacle-tower-env
cd obstacle-tower-env
pip3 install ./ 
cd ../

  3. [recomendation/discussion] I believe the config will run for 50m steps by default - maybe the tutorial should override this with 10m steps (as this seems to be what was recommended)

awjuliani commented 5 years ago

Thanks for pointing these issues out, @Sohojoe.

@ervteng Could you take a look and make the appropriate changes?

ervteng commented 5 years ago

@Sohojoe thanks for pointing out these issues!

For the config, I've put it to more than 10M intentionally, since depending on environment (e.g. for a fixed seed) the agent may continue to learn well past 10M. I erred on the side of too many steps, as you can always kill a run but it would be very disappointing to wake up in the morning and find that your run has stopped prematurely! I've added a blurb in the documentation describing how to change this.

Sohojoe commented 5 years ago

@ervteng that sounds good - I think the main thing is to have it clear in the guide