fix gamespy master server query for small list, handle binary response

[illwieckz]

Hi, the current gamespy master server query have many issues.

• It only works if the list is sent with more than two packets (1 packet header and more than 1 list packet), it's due to the fact the content of the first list packet is added after the final packet check to reading all the packet received.
• It does not work with servers lists in binary format, there is at least two server list format, the one with the text format \ip\nnn.nnn.nnn.nnn:nnnnn, and the one with the binary format (a simple array of bytes, like the internal qstat master packet list).

For example, currently the following query works (text format, many servers, so more than 2 packets):

qstat -gsm,bfield1942 gsm.qtracker.com

Currently the following query does not work (text format but not enough servers so only 2 packets, only one server list packer):

qstat -gsm,rune gsm.qtracker.com

Currently the following query does not work (binary format):

qstat -gsm,mohaa gsm.qtracker.com

So, this PR fixes these two issues and rewrite some part to get a cleaner and safer code:

• parse server list that have only two packets (header + list)
• parse binary server list
• check text server list against complete '\ip\' keyword instead of incomplete 'ip\' keyword
• only allocate memory needed
• do not rewrite rawpkt before reading it
• check if the header is well formed
• check is the text format is well formed
• print more debug information

This code was successfully tested against these use cases:

qstat -gsm,bfield1942 gsm.qtracker.com
qstat -gsm,rune gsm.qtracker.com
qstat -gsm,mohaa gsm.qtracker.com
qstat -gsm,rune master.333networks.com:28900
qstat -gsm,ut master.errorist.tk:28900
qstat -gsm,ut master.noccer.de:28900 

And some other combinations.

[illwieckz]

Note: this PR can be merged before others.

[stevenh]

Overall for new code blocks please use trailing brace style e.g.

if (condition1 || condition2) {
...
} else {
...
}

[illwieckz]

Is it really needed since all that will be revamped? I don't like to mix different style in the same block (like a function block), and all this stuff will be rewritten.

However, even if all these feedbacks are annoying, thank you very much for your meticulous review, for sure you read my code considerately. :wink:

[stevenh]

If it was all consistent with the existing style I would agree but atm its quite a mixed bag, so at the very least it should be self consistent :)

[illwieckz]

yeah, that part is one of the worst part (not only style) I ever read in qstat :scream: (one of the other very ugly qstat part is the template code :no_mouth: ), the kind of stuff you'll never accept these days, hopefully. :laughing:

[stevenh]

Any intention to address the outstanding comments?

[illwieckz]

code rebased, revamped and uncrustified

[illwieckz]

Things done in this PR (see first comment for details):

• fix text server list support (unsecure protocol)
• add support for binary server list (unsecure protocol)

Things not done in this PR:

• add secure protocol support

Only unsecure gamespy protocol is supported by qstat, qstat was never able to grok it (that's why XQF used gslist in the past for that task for example) so this part was left untouched, adding support for the secure protocol must be another PR (see gsmsalg.h for a reference implementation).