search

Unity-Technologies / uaal-example

Other
751 stars 238 forks source link

Update UAAL example to support Gradle 8 in 2023.3.0b7+ #99

Closed manugildev closed 9 months ago

manugildev commented 9 months ago

Purpose of this PR

This PR fixes compatibility with Unity 2023.3.0b7+ that ships with Gradle 8 and Android SDK 34.

Comments to reviewers

The changes introduced by this PR are backwards compatible, meaning we don't need to create a new 23LTS branch to just support 2023.3.0b7+.

VeryHappyYoung commented 9 months ago

Hello. Thank you for your work.

I think you need to update some lines in android.md. I read Tomas said "after gradle tools update, you can no longer use Android Studio 2021.3.1" so you need to update Android Studio version (and Unity version).

This was the android.md I tried to update in my PR last time but I am not sure if this will still work with gradle tools update.

BTW, do you happen to know which version of Unity the gradle tools update has been applied to? I guess we need to check the other branches for that.

manugildev commented 9 months ago

@VeryHappyYoung

I think you need to update some lines in android.md. ... This was the android.md I tried to update in my PR last time but I am not sure if this will still work with gradle tools update.

Just updated the android.md to indicate the new Android Studio version recommended to run the project. (2895624be74be187a821105c28c675d6d6b3bbf0)

BTW, do you happen to know which version of Unity the gradle tools update has been applied to? I guess we need to check the other branches for that.

The platform tools upgrade was done in 2023.3.0b7, I have tested this changes on 2023.3.0b6, 2023.2.0b3, and 2023.1.7f1 and everything works fine. My changes should be backward compatible, that's why I haven't suggested making a new 23LTS branch.