feat(theming): add icon to Windows executable

Universal-Debloater-Alliance / universal-android-debloater-next-generation

Cross-platform GUI written in Rust using ADB to debloat non-rooted Android devices. Improve your privacy, the security and battery life of your device.

GNU General Public License v3.0

1.74k stars 63 forks source link

feat(theming): add icon to Windows executable #470

Closed nozwock closed 1 month ago

nozwock commented 1 month ago

Fixes #462

Adds an icon resource to the windows executable using embed-resource.

The icon is just the logo-dark.png with a dark background and slightly curved borders. We should go with it unless we have a better design.

deepsource-io[bot] commented 1 month ago

Here's the code health analysis summary for commits 1eefb01..9cc1799. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Rust	❌ Failure	❗ 1 occurence introduced	View Check ↗
Test coverage	⚠️ Artifact not reported	Timed out: Artifact was never reported	View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

adhirajsinghchauhan commented 1 month ago

Thanks for this!

Since you're on Windows, could you post comparison sizes for both the debug & release builds?

nozwock commented 1 month ago

@adhirajsinghchauhan The screenshot was from a VM.

The executables were built using x86_64-pc-windows-gnu, and so the sizes with it are:

407M    debug/uad-ng.exe
13M release/uad-ng.exe

Not sure about msvc.

nozwock commented 1 month ago

Something to note is that the icon size would be about 130KB instead of 400KB, if we were to reduce the max icon size from 256px to 128px. If you're concerned about size that is.

Also, here are the file sizes with `x86_64-pc-windows-msvc`:	path	physical
C:\Users\user\Desktop\universal-android-debloater-next-generation\target\debug\uad-ng.exe	40.7 MiB
C:\Users\user\Desktop\universal-android-debloater-next-generation\target\release\uad-ng.exe	14.1 MiB