Universal-Debloater-Alliance / universal-android-debloater-next-generation

Cross-platform GUI written in Rust using ADB to debloat non-rooted Android devices. Improve your privacy, the security and battery life of your device.
GNU General Public License v3.0
2.27k stars 79 forks source link

pkg: sort and prettify uad_lists.json #483

Closed schbrns closed 3 months ago

schbrns commented 4 months ago

+VSCode built-in JSON Sort +VSCode built-in JSON Prettify (Alt+Shift+F)

schbrns commented 4 months ago

Sorry, I wasn't able to commit to the previous PR. It auto-closed after I deleted my commits.

I'll do the description changes in the next big commit.

deepsource-io[bot] commented 4 months ago

Here's the code health analysis summary for commits c2c0290..8645d13. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Rust LogoRust✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.
AnonymousWP commented 4 months ago

I'll do the description changes in the next big commit.

This should be done in a separate PR, not a next commit in this PR.

Blitz517 commented 4 months ago

I dont like sorting JSON when this lists looks already good to know on which is old or new by line number.

schbrns commented 4 months ago

I dont like sorting JSON when this lists looks already good to know on which is old or new by line number.

That's fair. My only real counter is that it's a pain to debloat through the unsorted JSON when I don't have access to UAD in full. A lot of times I'll just reference the JSON and debloat on-device.

I will say it wouldn't be too hard to pull package lists for each of the past few OEM devices and remove anything that isn't on the list. I saw somebody trying to update some One UI 2.5 stuff in a description, would be worth considering a cut-off or EOS for that sort of thing.

AnonymousWP commented 4 months ago

My only real counter is that it's a pain to debloat through the unsorted JSON when I don't have access to UAD in full. A lot of times I'll just reference the JSON and debloat on-device.

Why? What do you mean "UAD in full"? You can just clone it locally, then ctrl F. I'm also not sure if your refactor will sort it inside UAD-ng itself. 🤔

I will say it wouldn't be too hard to pull package lists for each of the past few OEM devices and remove anything that isn't on the list. I saw somebody trying to update some One UI 2.5 stuff in a description, would be worth considering a cut-off or EOS for that sort of thing.

Does it really matter though? The list is only 1.29MB.

schbrns commented 4 months ago

UAD-ng itself sorts by package label. And I agree, if the file size doesn't matter then I don't see the significance of very rough chronology.

Here's what I'm getting at when I say UAD is a resource outside of the software too:

Unsorted https://i.ibb.co/J30r1WS/Screenshot-20240529-170516-Brave-Nightly.jpg
Sorted https://i.ibb.co/VD4Brkr/Screenshot-20240529-170424-App-Manager.jpg
AnonymousWP commented 3 months ago

Even though I appreciate your effort, I do not see any benefit of it (ctrl F exists anyway). Also because it will always conflict with a package PR.