Closed schbrns closed 3 months ago
Sorry, I wasn't able to commit to the previous PR. It auto-closed after I deleted my commits.
I'll do the description changes in the next big commit.
Here's the code health analysis summary for commits c2c0290..8645d13
. View details on DeepSource ↗.
Analyzer | Status | Summary | Link |
---|---|---|---|
Rust | ✅ Success | View Check ↗ | |
Test coverage | ⚠️ Artifact not reported | Timed out: Artifact was never reported | View Check ↗ |
💡 If you’re a repository administrator, you can configure the quality gates from the settings.
I'll do the description changes in the next big commit.
This should be done in a separate PR, not a next commit in this PR.
I dont like sorting JSON when this lists looks already good to know on which is old or new by line number.
I dont like sorting JSON when this lists looks already good to know on which is old or new by line number.
That's fair. My only real counter is that it's a pain to debloat through the unsorted JSON when I don't have access to UAD in full. A lot of times I'll just reference the JSON and debloat on-device.
I will say it wouldn't be too hard to pull package lists for each of the past few OEM devices and remove anything that isn't on the list. I saw somebody trying to update some One UI 2.5 stuff in a description, would be worth considering a cut-off or EOS for that sort of thing.
My only real counter is that it's a pain to debloat through the unsorted JSON when I don't have access to UAD in full. A lot of times I'll just reference the JSON and debloat on-device.
Why? What do you mean "UAD in full"? You can just clone it locally, then ctrl F. I'm also not sure if your refactor will sort it inside UAD-ng itself. 🤔
I will say it wouldn't be too hard to pull package lists for each of the past few OEM devices and remove anything that isn't on the list. I saw somebody trying to update some One UI 2.5 stuff in a description, would be worth considering a cut-off or EOS for that sort of thing.
Does it really matter though? The list is only 1.29MB.
UAD-ng itself sorts by package label. And I agree, if the file size doesn't matter then I don't see the significance of very rough chronology.
Here's what I'm getting at when I say UAD is a resource outside of the software too:
Even though I appreciate your effort, I do not see any benefit of it (ctrl F exists anyway). Also because it will always conflict with a package PR.
+VSCode built-in JSON Sort +VSCode built-in JSON Prettify (Alt+Shift+F)