search

Universal-Debloater-Alliance / universal-android-debloater-next-generation

Cross-platform GUI written in Rust using ADB to debloat non-rooted Android devices. Improve your privacy, the security and battery life of your device.
GNU General Public License v3.0
1.72k stars 62 forks source link

bug(ci): lint fails #519

Open AnonymousWP opened 6 days ago

AnonymousWP commented 6 days ago

Describe the bug

With PRs, the linting step is failing: https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/actions/runs/9650187284/job/26615292076#step:6:718.

Expected behavior

I expect the checks to pass.

You have a solution?

No response

Provide logs

CI / GitHub Action logs: https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/actions/runs/9650187284/job/26615292076#step:6:718

Acknowledgements

adhirajsinghchauhan commented 6 days ago

Unused var is rarely a useful lint failure. I propose to disable that if possible. Most of the time it's only an annoyance.

However, does anyone know why clippy never reported this failure earlier? It's odd that a linter is flaky.

AnonymousWP commented 4 days ago

Yeah that's odd. Anyway, seems like it's a warning anyway, but still fails. Can you confirm that when I remove scanning for warnings (https://github.com/Universal-Debloater-Alliance/universal-android-debloater-next-generation/blob/main/.github/workflows/ci.yml#L41), this should solve the issue?

adhirajsinghchauhan commented 2 days ago

Removing -- -D warnings will still report warnings in logs, but it won't fail the build. This flag only serves to set the error code to a non-zero value.

AnonymousWP commented 2 days ago

Removing -- -D warnings will still report warnings in logs, but it won't fail the build. This flag only serves to set the error code to a non-zero value.

Any idea how to fix this? Isn't that what we want? We want to be informed about warnings, but that shouldn't make the build fail.