search

Universal-Debloater-Alliance / universal-android-debloater-next-generation

Cross-platform GUI written in Rust using ADB to debloat non-rooted Android devices. Improve your privacy, the security and battery life of your device.
GNU General Public License v3.0
2.23k stars 74 forks source link

bug(theme): `Auto` always `Light` (regression) #627

Open Rudxain opened 1 week ago

Rudxain commented 1 week ago

Describe the bug

dark-light v1.1.1 falls-back to Light unconditionally

I've been debugging this and I am 100% certain this is a bug in dark_light::detect

Expected behavior

Theme should be detected properly

You have a solution?

We could downgrade to v=1.0.0, until it's fixed upstream

Operating System

Linux

Distro version

Debian 13

Window System + Manager

Wayland + Mutter

Desktop Environment

GNOME 46

Provide logs

Irrelevant

Acknowledgements

sgse commented 1 week ago

Firstly, thanks for the app. :-)

As it was so difficult to recognize the logo, I made my own. I didn't know about the 'bug' then. If you don't include a .png in the .svg like in the second and third one above, then you also get a clear typeface. It is also much smaller in terms of memory requirements. Original has 15.1 k

ls | grep uad-ng
.rw-r--r--  65k root 15 Sep 19:55 uad-ng-1.png
.rw-r--r--  20k root 15 Sep 20:27 uad-ng-1.svg
.rw-r--r-- 4,3k root 15 Sep 20:42 uad-ng.svg

It works for me with the SVG on Arch Based Linux.

grafik

2024-09-16_13-45

2024-09-16_13-43

Rudxain commented 6 days ago

@sgse Thank you! but we should talk about it on #629

Frigyes06 commented 3 days ago

Cannot reproduce on Arch Plasma/kwin with Wayland

Frigyes06 commented 3 days ago

Wait I might be dumb, what do you mean by fall back to? Can you provide steps to reproduce?

Rudxain commented 3 days ago

According to frewsxcv/rust-dark-light#21, the code returns Light instead of Default when it fails to detect color-scheme. I know it fails on my system, because it always returns Light regardless of my GNOME theme