search

Universal-Omega / PortableInfobox

GNU General Public License v3.0
12 stars 11 forks source link

Vertically center data items #87

Closed LorenDB closed 2 years ago

LorenDB commented 2 years ago

Currently, the data content is not vertically centered (as of MediaWiki 1.38.4). This CSS change fixes that.

codecov[bot] commented 2 years ago

Codecov Report

Merging #87 (2dbc7c8) into master (9e77078) will increase coverage by 62.13%. The diff coverage is n/a.

@@              Coverage Diff              @@
##             master      #87       +/-   ##
=============================================
+ Coverage          0   62.13%   +62.13%     
- Complexity        0      511      +511     
=============================================
  Files             0       38       +38     
  Lines             0     1339     +1339     
=============================================
+ Hits              0      832      +832     
- Misses            0      507      +507
Impacted Files Coverage Δ
includes/services/Parser/Nodes/NodeImage.php 66.66% <0.00%> (ø)
includes/services/Parser/Nodes/NodeAudio.php 75.00% <0.00%> (ø)
includes/services/Parser/Nodes/NodeTitle.php 100.00% <0.00%> (ø)
includes/PortableInfoboxMagic.php 0.00% <0.00%> (ø)
includes/services/Helpers/PagePropsProxy.php 0.00% <0.00%> (ø)
includes/PortableInfoboxHooks.php 0.00% <0.00%> (ø)
...cludes/services/Parser/Nodes/NodeUnimplemented.php 100.00% <0.00%> (ø)
.../services/Helpers/PortableInfoboxParsingHelper.php 57.14% <0.00%> (ø)
...des/services/PortableInfoboxErrorRenderService.php 0.00% <0.00%> (ø)
...controllers/PortableInfoboxParserTagController.php 80.17% <0.00%> (ø)
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

SavageAlien commented 1 year ago

You might want to reconsider these changes - or going deeper to other rules to compensate - as the changes here have an effect on other elements.

Adding flex has a side effect of ruining the layout for data in horizontal-groups - as seen in this issue thread align-items: center; also messes with things like <sup> (superscripted) text like References which are meant to display in top corners of text.