Universal-Rom-Tools / Universal-XML-Scraper

Scraper de Rom
195 stars 46 forks source link

[bug] hashing on the pi + mame .zip inside files check #108

Closed giventofly closed 7 years ago

giventofly commented 7 years ago

Found an issue,

i was trying to see if the problem was from the hashing here (just trying stuff), regarding my problem posted here: games that the hash previously matched no longer match and now doing the hash of the files inside.

The problem is that it downloads the file list, extracts locally but trys to hash remotely (and it fails because the file doesn't exist).

http://pastebin.com/NzdsKFwF

slydisciple commented 7 years ago

I just finished scraping the 2000 roms that are on mame4all's game list. It only found 39% of them and took over 18 hours because of going into the zip file. This may, in fact, be the case... where the database only has 896 of the 2296 roms, but Im sure the database supports more. See pic for analytics. Im also supplying a list of game's filenames. Thanks. error gamelist.txt

Universal-Rom-Tools commented 7 years ago

It was a problem in the API. And it's corrected now...

Can you check and keep me up to date to know if I can close this issue ?

giventofly commented 7 years ago

yes, everything is working now :)

Universal-Rom-Tools commented 7 years ago

Great ;) I close the Issue ;)

Thank you