search

Universal-Rom-Tools / Universal-XML-Scraper

Scraper de Rom
196 stars 46 forks source link

Scraping /w mode "2 - FileName" not working #263

Open Zalgow opened 6 years ago

Zalgow commented 6 years ago

Hi,

I have some files, which CRCs are not in the Screenscraper DB, but the filenames are. So I switch the scraping mode to "2 - FileName", but still the existing files are not matched with the DB entries. I triple-checked the filenames against the DB and they fit 100%.

PS: I would love to contribute the missing CRCs, but the process seems to be quite slow. If, by any chance, it would be possible to raise my permission level @screenscraper.fr, I would add them directly by myself. (long-time and steady contributior at other Scraping/DB sites, for reference)

Universal-Rom-Tools commented 6 years ago

Have you an "exemple" that I can test ?

I know some modification were made on the API side for the filenames search (for exemple now when you have a dot in the filename like B.O.B.zip it must work ;) )

For the Adding CRC I know it's not the perfect process, but it's for preventing the DB pollution and the Accuracy of your Scrape ;)

Zalgow commented 6 years ago

Hi,

I may have found the reason (at least the direction to it) for my reported issue.

Is it possible, that with Filename-Mode, the Scraper not only matches based on the filename itself, but a combination aof filename + filesize (or other attributes)?

Universal-Rom-Tools commented 6 years ago

Sorry for the delay.

No Filesize or other attribute aren't used in the API when in "Filename mode". Only the filename. But the filename match engine are only based on the "rom" name. Not the "game" name.

So if you have "Super Mario Bros.zip" it should match "Super Mario Bros". But if The DB havent "Super Mario Bros." but only "Super Mario Bros [US]." it won't match...